Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Fixes for Gnome Extension #4391

Closed
wants to merge 33 commits into from
Closed

Various Fixes for Gnome Extension #4391

wants to merge 33 commits into from

Conversation

soumyaDghosh
Copy link
Contributor

@soumyaDghosh soumyaDghosh commented Oct 4, 2023 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Changes:

  • The gnome-sdk has webkit2gtk-4.1 files, but it also needs a layout just like webkit2gkt-4.0.
  • Changed the SNAPCRAFT in the layouts to CRAFT
  • Updated description[Gnome SDK now has Gnome-45 libraries also]

@soumyaDghosh soumyaDghosh changed the title Various Fixes for Gnome SDK Various Fixes for Gnome Extension Oct 4, 2023
sergio-costas
sergio-costas approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@sergio-costas sergio-costas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it seems that the linter has some complains...

sergiusens
sergiusens requested changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have not changed any unit tests, I would make 2 PRs, one for the text change and another for the layout changes

@soumyaDghosh
Copy link
Contributor Author

you have not changed any unit tests, I would make 2 PRs, one for the text change and another for the layout changes

Should I close this PR then?

@sergiusens
Copy link
Collaborator

you have not changed any unit tests, I would make 2 PRs, one for the text change and another for the layout changes

Should I close this PR then?

what I mean is that this PR is failing as you changed code but not their related unit tests

@sergiusens
Copy link
Collaborator

if you want to close and create two new from scratch PRs go ahead, or trim this down to one thing (the text change perhaps)

sergiusens and others added 17 commits November 17, 2023 18:24
@sergiusens @soumyaDghosh
fix: add part in snapcraft.yaml to build libgit2
03407f2 
Build libgit2 from source, also ensure we do not download any wheels.

Signed-off-by: Sergio Schvezov <[email protected]>
@mr-cal @soumyaDghosh
chore(remote-build): migrate LaunchpadClient and WorkTree (#4390)
6c358a4 
Signed-off-by: Callahan Kovacs <[email protected]>
@sergiusens @soumyaDghosh
ci: disable python 3.8 testing
9bcc0c7 
Signed-off-by: Sergio Schvezov <[email protected]>
@sergiusens @soumyaDghosh
fix(remote-build): warn instead of error when using unsupported bases
cc25806 
Signed-off-by: Sergio Schvezov <[email protected]>
@mr-cal @soumyaDghosh
feat(remote-build): new command logic (#4395)
866c428 
- Migrate the command logic used to orchestrate a remote build.
    - Some of this code was moved to a new class, RemoteBuild
- Store a copy of the project directory in the local cache
- Clean up the cache after a build completes
- Typing and linting updates

Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal @soumyaDghosh
chore: ignore types for pkg_resources (#4406)
8f8b866 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal @soumyaDghosh
chore(deps): update craft-providers to 1.18.0 (#4409)
5165183 
Signed-off-by: Callahan Kovacs <[email protected]>
@brlin-tw @mr-cal @soumyaDghosh
feat(plugins): add core20 support for pyproject.toml projects (#4087)
6004639 
LP: #2008237

Signed-off-by: 林博仁(Buo-ren Lin) <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
Co-authored-by: Callahan Kovacs <[email protected]>
@dependabot @soumyaDghosh
build(deps): bump urllib3 from 1.26.17 to 1.26.18 in /docs/.sphinx (#…
93042a3 
…4405)

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @soumyaDghosh
build(deps): bump urllib3 from 1.26.17 to 1.26.18 (#4404)
d0e3cf1 
Signed-off-by: dependabot[bot] <[email protected]>
@lengau @soumyaDghosh
chore: update Python version metadata (#4415)
ba6ea95
@lengau @soumyaDghosh
style: fix ruff format tox environment (#4416)
0548f4d
@lengau @soumyaDghosh
chore(deps): update ruff to 0.1.1 and fix lint issues (#4417)
9ec27cf
@mr-cal @soumyaDghosh
chore(pyproject): quote versions (#4423)
cd96dcd 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal @soumyaDghosh
fix(remote-build): parse --launchpad-timeout argument (#4426)
ed42603 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal @soumyaDghosh
chore: migrate dev environment to ubuntu 22.04 and python 3.10 (#4425)
facbcc6 
Signed-off-by: Callahan Kovacs <[email protected]>
@stephensp @soumyaDghosh
docs(TESTING.md): update commands (#4428)
7d3c35a 
Signed-off-by: Portia Stephens <[email protected]>
syu-w and others added 12 commits November 17, 2023 18:24
@syu-w @soumyaDghosh
build(deps): bump craft-providers to 1.19.1 (#4421) (#4429)
e3865d3 
Adds spread tests for `base: devel` spread tests and fixes multipass
spread tests.
@mr-cal @soumyaDghosh
fix(cli): catch remote-build errors
71f3b05 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal @soumyaDghosh
fix(remote-build): improve logging
1ffda79 
Signed-off-by: Callahan Kovacs <[email protected]>
@syu-w @soumyaDghosh
feat(linter): show missing libraries corresponding package
1b83ee9
@mr-cal @soumyaDghosh
tests(spread): add remote-build spread test
09965ed 
Signed-off-by: Callahan Kovacs <[email protected]>
@syu-w @soumyaDghosh
chore(log): hide command in output when pack failed (#4434)
142ba8d
@mr-cal @soumyaDghosh
ci: colorize tox and collapse sections (#4435)
2f28be5 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal @soumyaDghosh
build(deps): bump craft-providers to 1.19.2 (#4437)
32a27d6 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal @soumyaDghosh
docs(architectures): remove shorthand notation for core22 architectur…
1217381 
…es (#4436)

Signed-off-by: Callahan Kovacs <[email protected]>
@sergiusens @soumyaDghosh
feat: enable chisel (#4441)
6eba18e 
Signed-off-by: Sergio Schvezov <[email protected]>
@sergiusens @soumyaDghosh
feat: improve lifecycle messages (#4431)
ca40ab0 
Signed-off-by: Sergio Schvezov <[email protected]>
@tigarmo @soumyaDghosh
chore(ci): publish snaps for feature/ branches (#4447)
43e401c
@soumyaDghosh
Copy link
Contributor Author

recreating this PR, with some added changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiusens sergiusens sergiusens requested changes

@sergio-costas sergio-costas sergio-costas approved these changes

@kenvandine kenvandine Awaiting requested review from kenvandine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@soumyaDghosh @sergiusens @kenvandine @sergio-costas @mr-cal @brlin-tw @lengau @stephensp @syu-w @tigarmo